Skip to content

Bug: Support translations for Cookie Acquisition error#6917

Merged
david-livefront merged 1 commit into
mainfrom
add-translation-for-cookie-error
May 13, 2026
Merged

Bug: Support translations for Cookie Acquisition error#6917
david-livefront merged 1 commit into
mainfrom
add-translation-for-cookie-error

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR adds support for the Cookie Acquisition to be translated.

@david-livefront david-livefront requested a review from a team as a code owner May 13, 2026 18:59
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:bug Change Type - Bug labels May 13, 2026
@david-livefront david-livefront force-pushed the add-translation-for-cookie-error branch from 22a3608 to 9468904 Compare May 13, 2026 19:00
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.83%. Comparing base (8fe23ad) to head (8548893).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6917      +/-   ##
==========================================
- Coverage   85.92%   85.83%   -0.10%     
==========================================
  Files         857      985     +128     
  Lines       61757    64067    +2310     
  Branches     8982     9047      +65     
==========================================
+ Hits        53064    54989    +1925     
- Misses       5611     5973     +362     
- Partials     3082     3105      +23     
Flag Coverage Δ
app-data 17.29% <44.44%> (-0.03%) ⬇️
app-ui-auth-tools 19.86% <0.00%> (+0.29%) ⬆️
app-ui-platform 16.12% <22.22%> (+0.63%) ⬆️
app-ui-vault 27.92% <11.11%> (+0.56%) ⬆️
authenticator 6.37% <0.00%> (-0.01%) ⬇️
lib-core-network-bridge 4.14% <55.55%> (+0.01%) ⬆️
lib-data-ui 1.14% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront david-livefront force-pushed the add-translation-for-cookie-error branch from 9468904 to b754cf7 Compare May 13, 2026 19:08
@david-livefront david-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label May 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR replaces the hardcoded English message inside CookieRedirectException with a translatable string sourced from ResourceManager. The exception now takes message as a constructor parameter, CookieProvider exposes a new errorMessageString property, and NetworkCookieManagerImpl resolves the localized string via BitwardenString.your_request_was_interrupted_because_the_app_needed_to_reauthenticate. All call sites (production code in CookieInterceptor and GlideCookieInterceptor, the Authenticator placeholder CookieProvider, and every related unit test) were updated consistently, and the new string resource was added to ui/src/main/res/values/strings.xml following the snake_case naming convention.

Code Review Details

No findings.

@david-livefront david-livefront force-pushed the add-translation-for-cookie-error branch from b754cf7 to 724ecba Compare May 13, 2026 19:25
SaintPatrck
SaintPatrck previously approved these changes May 13, 2026
@david-livefront
Copy link
Copy Markdown
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue May 13, 2026
Merged via the queue into main with commit e4f030d May 13, 2026
24 checks passed
@david-livefront david-livefront deleted the add-translation-for-cookie-error branch May 13, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants