[PM-30584] Add unlock for key connector with SDK#19367
Merged
Merged
Conversation
Contributor
|
New Issues (25)Checkmarx found the following issues in this Pull Request
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19367 +/- ##
==========================================
+ Coverage 46.47% 46.83% +0.36%
==========================================
Files 3866 3881 +15
Lines 115231 116507 +1276
Branches 17549 17756 +207
==========================================
+ Hits 53553 54566 +1013
- Misses 59237 59461 +224
- Partials 2441 2480 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
#19422 has been merged. |
mzieniukbw
requested changes
Mar 11, 2026
mzieniukbw
previously approved these changes
Mar 16, 2026
JaredSnider-Bitwarden
requested changes
Apr 13, 2026
…into km/unlock-kc-with-sdk
|
JaredSnider-Bitwarden
approved these changes
Apr 13, 2026
mzieniukbw
approved these changes
Apr 13, 2026
Contributor
Author
|
Rust errors seem unrelated. |
nikwithak
pushed a commit
that referenced
this pull request
Apr 15, 2026
* Add unlock for key connector with SDK * Cleanup merge conflicts * Cleanup * Eslint error * Fix tests * Fix tests * Eslint fix * Fix comment * Prettier * Remove setting masterkeyencrypteduserkey to state * Remove unused enlint directive * Rename feature flag * Fix order of setting state * Fix test build * Fix cli * Eslint * Fix build error * Fix build error * Undo changes to development.json * Prevent unflagged changes * Apply feedback around flag caching * Apply feedback * Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-30584
📔 Objective
Adds unlock via the unlock service in the login strategies. The unlock service implements key-connector-unlock via the SDK.
📸 Screenshots