[PM-30584] Add unlock for key connector with SDK#19367
Open
[PM-30584] Add unlock for key connector with SDK#19367
Conversation
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
quexten
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19367 +/- ##
==========================================
+ Coverage 45.44% 45.52% +0.08%
==========================================
Files 3768 3773 +5
Lines 110969 111416 +447
Branches 16910 16919 +9
==========================================
+ Hits 50428 50721 +293
- Misses 58321 58475 +154
Partials 2220 2220 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
#19422 has been merged. |
mzieniukbw
requested changes
Mar 11, 2026
libs/auth/src/common/login-strategies/user-api-login.strategy.ts
Outdated
Show resolved
Hide resolved
mzieniukbw
previously approved these changes
Mar 16, 2026
mzieniukbw
previously approved these changes
Mar 17, 2026
…into km/unlock-kc-with-sdk
|
mzieniukbw
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-30584
📔 Objective
Adds unlock via the unlock service in the login strategies. The unlock service implements key-connector-unlock via the SDK.
📸 Screenshots