Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 3, 2025

Updates the public suffix list with the latest data from https://publicsuffix.org/list/public_suffix_list.dat

@github-actions github-actions bot added automated-pr PR created by workflow or other automation t:ci Updates to automated workflows labels Nov 3, 2025
@github-actions github-actions bot requested review from a team and matt-livefront as code owners November 3, 2025 00:33
@KatherineInCode KatherineInCode enabled auto-merge (squash) November 3, 2025 14:53
@claude
Copy link

claude bot commented Nov 3, 2025

Claude finished @github-actions[bot]'s task —— View job


PR Review: Update Public Suffix List

Summary of Changes

This PR updates the public suffix list data file from version 2025-10-26_13-56-05_UTC to 2025-10-29_17-39-25_UTC, incorporating the latest domain suffix registrations from publicsuffix.org.

Changes:

  • Version update: 30f4f4244c8e3b7b7885c
  • New domain suffixes added: 6 entries
  • Documentation updates: 6 comment lines added
  • Minor corrections: 1 submitter email updated
Detailed Changes

New Domain Suffixes:

  1. ia.ve - Venezuela AI domain with documentation reference
  2. cloudflare.app - Cloudflare application hosting
  3. gitbook.io - GitBook documentation platform
  4. statichost.page - Static hosting service
  5. directwp.eu - WordPress hosting (team.blue)
  6. wasmer.app - Wasmer WebAssembly platform

Documentation/Metadata:

  • Added reference link for Venezuela domains classification
  • Added submission information for new providers (GitBook, statichost.eu, Wasmer)
  • Updated team.blue submitter email from [email protected] to [email protected]

Critical Issues Found

None identified. This is a straightforward data file update with no critical issues.


Suggested Improvements

None required. The changes are appropriate for an automated public suffix list update.


Good Practices Observed

✅ Automated update process maintains consistency
✅ Version and commit metadata properly updated
✅ All new entries include proper documentation/submission attribution
✅ File format adheres to the Public Suffix List standard
✅ Changes are verified against the canonical source at publicsuffix.org


Action Items

For the author:

  • ✅ No action required - PR is ready to merge

For reviewers:

  1. Verify CI checks pass (currently in progress: tests, scan)
  2. Confirm the update aligns with the organization's scheduled maintenance window

Technical Context

The public_suffix_list.dat file is used by DomainName.swift (BitwardenKit/Core/Platform/Utilities/DomainName.swift:206) to parse URLs and extract base domains. The parser:

  • Loads this file from the bundle at runtime
  • Parses normal rules, wildcard rules (prefix: *), and exception rules (prefix: !)
  • Uses the parsed data to correctly identify top-level domains, second-level domains, and subdomains

All 6 new entries are normal rules (no wildcards or exceptions), which integrate seamlessly with the existing parsing logic. The test suite (DomainNameTests.swift) validates the parser's behavior with various rule types and would catch any formatting issues.


CI Status

  • ✅ Lint workflow: passed
  • ⏳ Test Password Manager: in progress
  • ⏳ Test Authenticator: in progress
  • ⏳ Scan: in progress

@github-actions
Copy link
Contributor Author

github-actions bot commented Nov 3, 2025

Logo
Checkmarx One – Scan Summary & Detailsd1cae382-23b9-4135-aa7e-128b1398c015

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.94%. Comparing base (7a9aa82) to head (6962a31).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2093      +/-   ##
==========================================
- Coverage   85.28%   82.94%   -2.34%     
==========================================
  Files        1695     1973     +278     
  Lines      144602   160775   +16173     
==========================================
+ Hits       123319   133359   +10040     
- Misses      21283    27416    +6133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode merged commit 47bfe3c into main Nov 3, 2025
14 checks passed
@KatherineInCode KatherineInCode deleted the cron-sync-public-suffix-list/36-sync branch November 3, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-pr PR created by workflow or other automation t:ci Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants