Skip to content

[PM-30584] Add UserInitCryptoMethod::KeyConnectorUrl#810

Merged
quexten merged 9 commits intomainfrom
km/key-connector-url-decrypt-option
Mar 11, 2026
Merged

[PM-30584] Add UserInitCryptoMethod::KeyConnectorUrl#810
quexten merged 9 commits intomainfrom
km/key-connector-url-decrypt-option

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Mar 4, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30584

📔 Objective

Adds the user init crypto method key-connector-url, which directly gets the key-connector-key within the SDK. This gets us closer to dropping the master-key support entirely in clients.

🚨 Breaking Changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Logo
Checkmarx One – Scan Summary & Detailse76c5939-aa45-4cde-8f8d-d0885ff7f02f

Great job! No new security vulnerabilities introduced in this pull request

@quexten quexten force-pushed the km/key-connector-url-decrypt-option branch from 4450335 to ee947cb Compare March 4, 2026 13:52
@quexten quexten changed the title km/key connector url decrypt option Add UserInitCryptoMethod::KeyConnectorUrl Mar 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

🔍 SDK Breaking Change Detection Results

SDK Version: km/key-connector-url-decrypt-option (6f9d814)
Completed: 2026-03-10 10:29:05 UTC
Total Time: 249s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.28%. Comparing base (bdce094) to head (6f9d814).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...tes/bitwarden-crypto/src/keys/key_connector_key.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
+ Coverage   81.71%   82.28%   +0.56%     
==========================================
  Files         346      346              
  Lines       41126    41420     +294     
==========================================
+ Hits        33605    34081     +476     
+ Misses       7521     7339     -182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quexten quexten changed the title Add UserInitCryptoMethod::KeyConnectorUrl [PM-30584] Add UserInitCryptoMethod::KeyConnectorUrl Mar 5, 2026
@quexten quexten marked this pull request as ready for review March 5, 2026 11:11
@quexten quexten requested review from a team as code owners March 5, 2026 11:11
@quexten quexten requested a review from eligrubb March 5, 2026 11:11
@quexten quexten requested a review from a team as a code owner March 8, 2026 08:58
mzieniukbw
mzieniukbw previously approved these changes Mar 8, 2026
@sonarqubecloud
Copy link

@quexten quexten requested a review from mzieniukbw March 10, 2026 10:52
@quexten quexten merged commit 3db78d5 into main Mar 11, 2026
80 checks passed
@quexten quexten deleted the km/key-connector-url-decrypt-option branch March 11, 2026 08:15
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants