Skip to content

[PM-33290] Add stop gap solution for rehydration auth/crypto state#819

Merged
Hinton merged 1 commit intomainfrom
arch/tmp-cli-login-env
Mar 9, 2026
Merged

[PM-33290] Add stop gap solution for rehydration auth/crypto state#819
Hinton merged 1 commit intomainfrom
arch/tmp-cli-login-env

Conversation

@Hinton
Copy link
Member

@Hinton Hinton commented Mar 6, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33290

📔 Objective

Instead of rehydrating auth/crypto state we can just always call login before the actual operation. This adds two environment variables which when set will log you in prior to calling the appropriate command.

This is a temporary solution until rehydration is in place.

@Hinton Hinton requested a review from a team as a code owner March 6, 2026 09:38
@Hinton Hinton requested a review from djsmith85 March 6, 2026 09:38
@djsmith85 djsmith85 requested review from dani-garcia and removed request for djsmith85 March 6, 2026 09:40
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Logo
Checkmarx One – Scan Summary & Details72e1aff1-2b95-4547-88b8-90f5161ba283

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

@Hinton Hinton requested a review from coroiu March 6, 2026 09:45
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

🔍 SDK Breaking Change Detection Results

SDK Version: arch/tmp-cli-login-env (6fe1cbb)
Completed: 2026-03-06 09:51:13 UTC
Total Time: 246s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.73%. Comparing base (f8a75af) to head (6fe1cbb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bw/src/main.rs 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
- Coverage   81.77%   81.73%   -0.04%     
==========================================
  Files         344      344              
  Lines       41116    41135      +19     
==========================================
  Hits        33623    33623              
- Misses       7493     7512      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable enough

@Hinton Hinton changed the title Add stop gap solution for rehydration auth/crypto state [PM-33290] Add stop gap solution for rehydration auth/crypto state Mar 9, 2026
@Hinton Hinton merged commit c74b7d1 into main Mar 9, 2026
59 checks passed
@Hinton Hinton deleted the arch/tmp-cli-login-env branch March 9, 2026 09:52
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants