[PM-33267] Password history encryption and email forwarding encrypting using local data user key for WASM by mzieniukbw · Pull Request #824 · bitwarden/sdk-internal

mzieniukbw · 2026-03-07T18:55:14Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33267

Requires #806

📔 Objective

Adds a stop-gap solution for WASM, for encryption and decryption with local user data key, until tools migrate to use SDK clients directly for encryption.

🚨 Breaking Changes

# Conflicts: # crates/bitwarden-core/src/client/encryption_settings.rs # crates/bitwarden-core/src/key_management/crypto.rs

…optimizations

…olution for WASM

github-actions · 2026-03-07T18:59:41Z

Checkmarx One – Scan Summary & Details – c41b2fab-9df7-44bb-9e34-6c02eef7df72

Great job! No new security vulnerabilities introduced in this pull request

github-actions · 2026-03-07T19:02:54Z

🔍 SDK Breaking Change Detection Results

SDK Version: km/pm-33267-use-local-user-data-key (23a2cba)
Completed: 2026-03-09 12:12:48 UTC
Total Time: 277s

Client	Status	Details
typescript	✅ No breaking changes detected	TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

codecov · 2026-03-07T19:14:59Z

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.71%. Comparing base (298f323) to head (23a2cba).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...bitwarden-core/src/key_management/crypto_client.rs	0.00%	22 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   81.75%   81.71%   -0.05%     
==========================================
  Files         346      346              
  Lines       41104    41126      +22     
==========================================
  Hits        33605    33605              
- Misses       7499     7521      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ocal-user-data-key

quexten

Looks good; I have a nit on docs and a thought, but this is optional.

crates/bitwarden-core/src/key_management/crypto_client.rs

mzieniukbw · 2026-03-09T12:02:42Z

Since mobile does not use sdk-managed repositories yet, we can't change the PasswordHistory to use the LocalUserKey yet. Separated into https://bitwarden.atlassian.net/browse/PM-33158

sonarqubecloud · 2026-03-09T12:06:49Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

…rd history encryption and email forwarding encrypting using local data user key for WASM (bitwarden/sdk-internal#824)

mzieniukbw added 20 commits March 3, 2026 14:28

local user data key

c656dc1

sync guard before async refactor

655c1b1

initialize_local_user_data_key non wasm specific

23f3394

Merge branch 'main' into km/pm-31055-local-user-data-key

3e9e9b9

# Conflicts: # crates/bitwarden-core/src/client/encryption_settings.rs # crates/bitwarden-core/src/key_management/crypto.rs

bad merge - missing closing bracket

4c51944

wasm debug build failing due to missing dependencies and unnecessary …

96cd790

…optimizations

use EncString instead of B64 in state

7d1c150

store as wrapped, SDK managed state, siplified guard

d49badc

too much information in tracing

5e9ddb8

revert new symmetric key id

6e7a88d

updated log messages

3c9d7a3

remove unnecessary import

9676d2f

new key id, load into state on crypto init

c172eb0

comments

a06b4f0

sdk managed repositories registered for tests

7dae3f2

test import

b0c4e72

fix test failures

aade30d

clippy

c16a6fd

rename from user key

d41bacc

password history encryption using local data user key with stop gap s…

e932cf8

…olution for WASM

mzieniukbw added 2 commits March 7, 2026 22:19

user id as key for SDK managed wrapped local user data key state repo

b02dd27

Merge branch 'km/pm-31055-local-user-data-key' into km/pm-33267-use-l…

f2104ef

…ocal-user-data-key

mzieniukbw mentioned this pull request Mar 8, 2026

[PM-31112] Decouple local tools crypto from user key bitwarden/clients#19433

Open

mzieniukbw added 2 commits March 8, 2026 01:32

exit gracefully on missing repository registration

5aee9d1

Merge branch 'km/pm-31055-local-user-data-key' into km/pm-33267-use-l…

21dd71c

…ocal-user-data-key

quexten reviewed Mar 9, 2026

View reviewed changes

crates/bitwarden-core/src/key_management/crypto_client.rs Outdated Show resolved Hide resolved

crates/bitwarden-core/src/key_management/crypto_client.rs Show resolved Hide resolved

unnecessary docs removal

aa4859b

Base automatically changed from km/pm-31055-local-user-data-key to main March 9, 2026 11:55

Merge branch 'main' into km/pm-33267-use-local-user-data-key

bf8b797

mzieniukbw marked this pull request as ready for review March 9, 2026 11:57

mzieniukbw requested review from a team as code owners March 9, 2026 11:57

mzieniukbw requested review from gbubemismith and quexten March 9, 2026 11:57

revert using local user data

23a2cba

mzieniukbw removed request for a team and gbubemismith March 9, 2026 12:00

mzieniukbw changed the title ~~[PM-33267] Password history encryption using local data user key with stop gap solution for WASM~~ [PM-33267] Password history encryption and email forwarding encrypting using local data user key for WASM Mar 9, 2026

mzieniukbw enabled auto-merge (squash) March 9, 2026 12:13

quexten approved these changes Mar 9, 2026

View reviewed changes

mzieniukbw merged commit bdce094 into main Mar 9, 2026
60 of 61 checks passed

mzieniukbw deleted the km/pm-33267-use-local-user-data-key branch March 9, 2026 12:23

This was referenced Mar 9, 2026

Update SDK to 6e86b7d (2.0.0-5020-968065e) bitwarden/ios#2395

Open

Update SDK to 2.0.0-5676-14521973 bitwarden/android#6615

Merged

bw-ghapp bot mentioned this pull request Mar 16, 2026

Update SDK to 2.0.0-5730-42edf30c bitwarden/android#6677

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-33267] Password history encryption and email forwarding encrypting using local data user key for WASM#824

[PM-33267] Password history encryption and email forwarding encrypting using local data user key for WASM#824
mzieniukbw merged 27 commits intomainfrom
km/pm-33267-use-local-user-data-key

mzieniukbw commented Mar 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

quexten left a comment

Uh oh!

Uh oh!

Uh oh!

mzieniukbw commented Mar 9, 2026

Uh oh!

sonarqubecloud bot commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mzieniukbw commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎟️ Tracking

📔 Objective

🚨 Breaking Changes

Uh oh!

github-actions bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Great job! No new security vulnerabilities introduced in this pull request

Uh oh!

github-actions bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 SDK Breaking Change Detection Results

Uh oh!

codecov bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

quexten left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mzieniukbw commented Mar 9, 2026

Uh oh!

sonarqubecloud bot commented Mar 9, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mzieniukbw commented Mar 7, 2026 •

edited

Loading

github-actions bot commented Mar 7, 2026 •

edited

Loading

github-actions bot commented Mar 7, 2026 •

edited

Loading

codecov bot commented Mar 7, 2026 •

edited

Loading