[PM-31711] Remove unused auth token and user agent#831
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #831 +/- ##
=======================================
Coverage 82.77% 82.77%
=======================================
Files 353 353
Lines 42301 42285 -16
=======================================
- Hits 35014 35003 -11
+ Misses 7287 7282 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Patrick-Pimentel-Bitwarden
left a comment
There was a problem hiding this comment.
👍 Auth changs are minimal
|
@dani-garcia could you help me understand what (if anything) needs to be updated if we ever see that we've introduced breaking changes like this pr has in that "SDK Breaking Change Detection Results" github actions section? |
|
@Patrick-Pimentel-Bitwarden The reported breaking change is from the PR previously merged into main: #829, which has a client PR fixing it already: bitwarden/clients#19433. This PR shouldn't contain any external breaking changes itself. In the general case, you should document any breaking breaking changes and how to fix them in the PR description. I don't think we have a specific format, just whatever you think would be helpful for someone trying to update the SDK version. Then other teams like mobile can more easily know how to fix those breaking changes. The CI action is just a reminder so you don't accidentally introduce breaking changes, but it does have some false positives when main has some breaking changes that haven't been solved yet on clients. |
6a4fa02
# Conflicts: # crates/bw/src/vault/sync.rs
fc87504
|
Resolved the conflict with #661, which removed the vault-owned sync file |
|
… unused auth token and user agent (bitwarden/sdk-internal#831)




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-31711
📔 Objective
Now that the authentication token is handled by the middleware and the user agent is set by default during client construction, we can remove these fields from the API
Configurationstructs, as they are unused.🚨 Breaking Changes