Skip to content

[PM-33374] Add CiphersClient::get_all(), which mimics list() but returns CipherView instead of CipherListView#833

Merged
nikwithak merged 2 commits intomainfrom
vault/pm-33374
Mar 11, 2026
Merged

[PM-33374] Add CiphersClient::get_all(), which mimics list() but returns CipherView instead of CipherListView#833
nikwithak merged 2 commits intomainfrom
vault/pm-33374

Conversation

@nikwithak
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33374

📔 Objective

CiphersClient::list() returns a CipherListView[], when the web client expects a CipherView[]. Since CipherListView is needed for some clients for performance reasons, this adds a separate method get_all(), which deals with CipherViews. It's otherwise identical to the list() implementation.

@nikwithak nikwithak requested a review from gbubemismith March 10, 2026 21:59
@nikwithak nikwithak requested review from a team as code owners March 10, 2026 21:59
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Logo
Checkmarx One – Scan Summary & Details93ac694b-b0e1-4f31-a0b8-a34fd08dd454

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

🔍 SDK Breaking Change Detection Results

SDK Version: vault/pm-33374 (4881549)
Completed: 2026-03-10 23:10:04 UTC
Total Time: 247s

Client Status Details
typescript ❌ Breaking changes detected TypeScript compilation failed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@gbubemismith
Copy link
Contributor

@nikwithak looks good. Lint check is failing

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.28%. Comparing base (329760a) to head (4881549).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...es/bitwarden-vault/src/cipher/cipher_client/get.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   82.31%   82.28%   -0.04%     
==========================================
  Files         346      346              
  Lines       41434    41450      +16     
==========================================
  Hits        34108    34108              
- Misses       7326     7342      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nikwithak nikwithak merged commit e522634 into main Mar 11, 2026
58 checks passed
@nikwithak nikwithak deleted the vault/pm-33374 branch March 11, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants