Conversation
…iew instead of CipherListView
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Contributor
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Contributor
|
@nikwithak looks good. Lint check is failing |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
==========================================
- Coverage 82.31% 82.28% -0.04%
==========================================
Files 346 346
Lines 41434 41450 +16
==========================================
Hits 34108 34108
- Misses 7326 7342 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gbubemismith
approved these changes
Mar 11, 2026
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33374
📔 Objective
CiphersClient::list() returns a CipherListView[], when the web client expects a CipherView[]. Since CipherListView is needed for some clients for performance reasons, this adds a separate method get_all(), which deals with CipherViews. It's otherwise identical to the list() implementation.