Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
- Coverage 82.43% 82.30% -0.14%
==========================================
Files 350 350
Lines 41735 41498 -237
==========================================
- Hits 34404 34153 -251
- Misses 7331 7345 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crates/bw/src/platform/sync.rs
Outdated
| } | ||
|
|
||
| /// Temporary sync implementation so you can call `bw sync` and have it do something. | ||
| pub(crate) async fn execute_sync(client: PasswordManagerClient, _args: SyncArgs) -> CommandResult { |
There was a problem hiding this comment.
I think this would be best if we moved this method to be part of SyncArgs:
impl SyncArgs {
pub async fn run(&self, client: PasswordManagerClient) -> ... {}
}One of the benefits of doing it this way is that you don't require importing the loose function in main.rs, which is going to get huge if we have to import them all.
|
…-sync in cli and add temporary sync command (bitwarden/sdk-internal#835)
2 participants
🎟️ Tracking
📔 Objective
Wire up the new sync infrastructure in the CLI and add a skeleton sync command which can be used during development.