Skip to content

Fix build for uniffi targets#837

Merged
nikwithak merged 1 commit intomainfrom
vault/pm-33427/fix-uniffi-build
Mar 11, 2026
Merged

Fix build for uniffi targets#837
nikwithak merged 1 commit intomainfrom
vault/pm-33427/fix-uniffi-build

Conversation

@nikwithak
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33427

📔 Objective

Fixes the uniffi builds by removing feature checks for the DecryptCipherResult type.

@nikwithak nikwithak requested review from a team as code owners March 11, 2026 18:38
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsef7a8cc6-69c2-45e4-b85d-b0e37e3fc33d

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🔍 SDK Breaking Change Detection Results

SDK Version: vault/pm-33427/fix-uniffi-build (646a0ee)
Completed: 2026-03-11 18:51:12 UTC
Total Time: 281s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@nikwithak nikwithak merged commit fcd0208 into main Mar 11, 2026
56 checks passed
@nikwithak nikwithak deleted the vault/pm-33427/fix-uniffi-build branch March 11, 2026 19:00
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.40%. Comparing base (e522634) to head (646a0ee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #837   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files         350      350           
  Lines       41751    41751           
=======================================
  Hits        34404    34404           
  Misses       7347     7347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants