feat: fix how needs_bootstrap works to match what clients need#856
Merged
feat: fix how needs_bootstrap works to match what clients need#856
Conversation
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
djsmith85
approved these changes
Mar 18, 2026
|
Contributor
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
bw-ghapp bot
pushed a commit
to bitwarden/sdk-swift
that referenced
this pull request
Mar 18, 2026
…ds_bootstrap works to match what clients need (bitwarden/sdk-internal#856)
djsmith85
added a commit
that referenced
this pull request
Mar 18, 2026
djsmith85
added a commit
that referenced
this pull request
Mar 18, 2026
## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Fixes failing tests caused by #856 ## 🚨 Breaking Changes <!-- Does this PR introduce any breaking changes? If so, please describe the impact and migration path for clients. If you're unsure, the automated TypeScript compatibility check will run when you open/update this PR and provide feedback. For breaking changes: 1. Describe what changed in the client interface 2. Explain why the change was necessary 3. Provide migration steps for client developers 4. Link to any paired client PRs if needed Otherwise, you can remove this section. --> Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
Required fix for Daniels PR
🚨 Breaking Changes