Remove concept of SDK SME ownership group#950
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
🔍 SDK Breaking Change Detection ResultsSDK Version:
| typescript | ❌ Breaking changes detected | Compilation failed with new SDK version. A corresponding pull request addressing the breaking changes MUST be ready for merge in bitwarden/clients. - View Details | | android | ❌ Breaking changes detected | Compilation failed with new SDK version. A corresponding pull request addressing the breaking changes MUST be ready for merge in bitwarden/android. - View Details |Breaking change detection completed. View SDK workflow |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
=======================================
Coverage 84.66% 84.66%
=======================================
Files 409 409
Lines 51493 51493
=======================================
Hits 43597 43597
Misses 7896 7896 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR modifies only Code Review DetailsNo findings. The diff is internally consistent: every |
|
@Hinton I talked to @dani-garcia about this, and he already gets notified of |
|
I resolved conflicts I caused by approving #1019, which added the |
|




📔 Objective
As we mature in our usage of the SDK, and we have more PRs coming in, we run the risk of overwhelming those few engineers who are in the
team-sdk-smegroup.This PR proposes that we remove this phase of the SDK onboarding process, and teams will move straight from partnership with Platform as co-owners to full owners of their domain.
Note that this does add
team-platform-devas shared codeowners for the/key-managementdirectory inbitwarden-core. The reasoning there is that Platform should be aware and working with KM to actively shrink the footprint of code inbitwarden-coreand not in another, KM-owned, crate.🚨 Breaking Changes