Skip to content

Remove concept of SDK SME ownership group#950

Merged
trmartin4 merged 3 commits into
mainfrom
platform/ownership-changes
May 4, 2026
Merged

Remove concept of SDK SME ownership group#950
trmartin4 merged 3 commits into
mainfrom
platform/ownership-changes

Conversation

@trmartin4
Copy link
Copy Markdown
Member

@trmartin4 trmartin4 commented Apr 13, 2026

📔 Objective

As we mature in our usage of the SDK, and we have more PRs coming in, we run the risk of overwhelming those few engineers who are in the team-sdk-sme group.

This PR proposes that we remove this phase of the SDK onboarding process, and teams will move straight from partnership with Platform as co-owners to full owners of their domain.

Note that this does add team-platform-dev as shared codeowners for the /key-management directory in bitwarden-core. The reasoning there is that Platform should be aware and working with KM to actively shrink the footprint of code in bitwarden-core and not in another, KM-owned, crate.

🚨 Breaking Changes

@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details60240e2b-e064-4bcd-ae94-d69d19890016

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 13, 2026

🔍 SDK Breaking Change Detection Results

SDK Version: platform/ownership-changes (4c43a86)
Completed: 2026-04-13 20:34:07 UTC
Total Time: 277s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

| typescript | ❌ Breaking changes detected | Compilation failed with new SDK version. A corresponding pull request addressing the breaking changes MUST be ready for merge in bitwarden/clients. - View Details |

| android | ❌ Breaking changes detected | Compilation failed with new SDK version. A corresponding pull request addressing the breaking changes MUST be ready for merge in bitwarden/android. - View Details |

Breaking change detection completed. View SDK workflow

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.66%. Comparing base (1c5ef5e) to head (5fc9d02).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #950   +/-   ##
=======================================
  Coverage   84.66%   84.66%           
=======================================
  Files         409      409           
  Lines       51493    51493           
=======================================
  Hits        43597    43597           
  Misses       7896     7896           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trmartin4 trmartin4 changed the title Remove team-sdk-sme concept Remove concept of SDK SME ownership group May 1, 2026
@trmartin4 trmartin4 added the ai-review Request a Claude code review label May 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR modifies only .github/CODEOWNERS to remove the team-sdk-sme co-ownership tier and renumbers the ownership-model legend accordingly. It also adds team-platform-dev as a co-owner for crates/bitwarden-core/src/key_management/**, with the stated rationale of helping shrink the bitwarden-core footprint over time. No source code, build, or runtime behavior is affected.

Code Review Details

No findings. The diff is internally consistent: every team-sdk-sme reference is removed (verified — no orphaned references remain in the repo), the legend renumbering matches the deleted tier, and the section header rename ("KM Co-owned files" → "Team-owned folders in other crates") aligns with the broader ownership-model simplification described in the PR.

@trmartin4 trmartin4 marked this pull request as ready for review May 1, 2026 17:12
@trmartin4 trmartin4 requested a review from a team as a code owner May 1, 2026 17:12
@trmartin4 trmartin4 requested review from Hinton, dani-garcia and dereknance and removed request for dereknance May 1, 2026 17:12
@trmartin4
Copy link
Copy Markdown
Member Author

@Hinton I talked to @dani-garcia about this, and he already gets notified of sdk-internal PRs from Github directly through email notifications, and I proposed that we remove this group to avoid any confusion around whether teams need to wait on them for review, as more teams come on board to the SDK. If you are deriving value from it we can keep it, but we felt like it might not be worth it at this time.

@dereknance
Copy link
Copy Markdown
Contributor

I resolved conflicts I caused by approving #1019, which added the bitwarden-collections crate to Admin Console's ownership (plus Platform) and sorted the Team-owned crates section alphabetically.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 1, 2026

@trmartin4 trmartin4 merged commit d44de60 into main May 4, 2026
61 checks passed
@trmartin4 trmartin4 deleted the platform/ownership-changes branch May 4, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants