[legacy-framework] Major internal refactor + add multiple entry points + change all imports to be from blitz + rename getSessionContext to getSession + other fixes#2039
Conversation
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
Contributor
|
Size Change: -33.4 kB (-13%) 👏 Total Size: 230 kB
ℹ️ View Unchanged
|
MrLeebo
previously approved these changes
Mar 3, 2021
Member
MrLeebo
left a comment
MrLeebo
left a comment
There was a problem hiding this comment.
This looks really good! The imports make a lot more sense now.
Based on the automated checks, it looks like some breaking changes still need to be fixed in the examples/ apps, but other then that, overall I'd say this is a step in the right direction! 💪
itsdillon
changed the title
blitz + rename getSessionContext to getSession + other fixesblitz + rename getSessionContext to getSession + other fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: blitz-js/legacy-framework#928
Closes: blitz-js/legacy-framework#516
What are the changes and their implications?
@blitzjs/core, like@blitzjs/core/image,@blitzjs/core/document,@blitzjs/core/server, etcblitz, but with the new babel plugin added in this PR, imports are remapped to their dedicated entrypoint. This optimizes DX and bundle sizes at the same timedate-fnsas a dependencyzodas a dependency (now a peer dependency)@blitzjs/serverinto@blitzjs/core/server@blitzjs/servernow only deals with build time operations. And it will go away once we fork next.jscore/src/supertokens.tsmoved tocore/src/auth/auth-client.tsserver/src/supertokens.tsmoved tocore/src/server/auth/sessions.tsBreaking changes:
Checklist