Added variation coefficient #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nils-braun
reviewed
Apr 5, 2020
| """ | ||
| mean = np.mean(x) | ||
| if mean != 0: | ||
| return np.std(x) / np.mean(x) |
Collaborator
There was a problem hiding this comment.
You could save some computing time (even though not really needed) by using your already calculated mean here
nils-braun
reviewed
Apr 5, 2020
| @set_property("fctype", "simple") | ||
| def variation_coefficient(x): | ||
| """ | ||
| Returns the variation coefficient of x |
Collaborator
There was a problem hiding this comment.
Could you include a short sentence on what the variant coefficient is (e.g. std / mean)?
Collaborator
|
Nice! Thanks for this PR! Just two very small comments |
…ime of variation coefficient by reusing precomputed mean
Contributor
Author
|
I completed the description and added your review on code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added coefficient of variation to have a relative value for standard deviation.
variation_coefficient = np.std(X) / np.mean(X)
Main problem is that we cannot compute the variable when the mean is 0, I chose to return missing value in this case.