Bnd Run File Editor: “Resolve” button stopped working in Maven workspaces since Bndtools 7.1.0

[sad-poet]

Starting with Bndtools 7.1.0, opening a *.bndrun file in a Maven-only workspace and clicking the Resolve button results in a NullPointerException (see below).

The problem is not reproduced when using Bndtools 7.0.0.

Environment

• Bndtools 7.1.0.202411251545 (installed from https://bndtools.org/bndtools.p2.repo/7.1.0/)
  • Git-Descriptor: 7.0.0.DEV-1660-g47e504d78
  • Git-SHA: 47e504d7881ba466703c55a8dca7b0578561582d
• Eclipse Temurin JDK 21.0.5
• Eclipse IDE for Java Developers 2024-09
• Eclipse Java Development Tools 3.19.600.v20240903-0240
• Eclipse PDE is not installed
• Apache Maven 3.9.9
• bnd-maven-plugin 7.1.0
• Devuan GNU+Linux codename Ceres (corresponding to Debian sid/unstable)

It was also possible to reproduce the error using Eclipse 2024-12 preview version, and on Windows 11.

Steps to reproduce

1. Install Eclipse IDE (from Eclipse Installer) and latest Bndtools (from Eclipse Marketplace Client), including Bndtools m2e integration feature.
2. Clone the example project and open it in Eclipse IDE: https://github.com/sad-poet/bndtools-resolve-npe-reproducer
3. Open app/app.bndrun file in Bnd Run File Editor.
4. Click Resolve button.

Expected result

There should be no error. A Resolution Results window should open, displaying the required resources used to create the Run Bundles list.

Actual result

The following error message is displayed in the Resolution Results window:

Exception during resolution.
java.lang.NullPointerException: Cannot invoke "aQute.bnd.build.Project.get(String)" because "project" is null
	at biz.aQute.resolve.RunResolution.resolve(RunResolution.java:101)
	at org.bndtools.core.resolve.ResolveOperation.lambda$run$0(ResolveOperation.java:62)
	at org.bndtools.core.resolve.ResolveOperation.coordinate(ResolveOperation.java:102)
	at org.bndtools.core.resolve.ResolveOperation.run(ResolveOperation.java:52)
	at org.bndtools.core.resolve.ResolveJob.run(ResolveJob.java:89)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

No new errors appear in the Eclipse’s Error Log view.

The problem persists in all Maven projects that use bnd-maven-plugin. I was also able to reproduce the error when trying to resolve the app/app.bndrun file in a different example project found at https://github.com/fipro78/osgi-jakartars/tree/main/jakartars.

Workaround

If bnd-resolver-maven-plugin is set up, the command line mvn bnd-resolver:resolve can be used and works as expected.

[chrisrueger]

Thanks @sad-poet for the detailed report. Seems this is related to:

cd21a96#diff-38351aedb1322e930095be9f6746dd4d6aecc5fc660f2656cebe14f3076ed93dR100-R107

I see some options:

• use actualProperties instead of project (assuming this this is not null... the comment of the method suggests project is only used for reporting errors)
• or check project for null (but this might be incorrect too, because then the -resolve property is ignored)

Or find out why project is null in a m2e project. I assume this has something to do with that it is a maven project and not a bnd workspace model project.

One caller is

fbc917c#diff-a4b407ab5fd64c74fc1c5decc823f997e3ba96bc4aefda5829aa7153d52d9ba9L57-R60

Project run = model.getOwner(Project.class)
					.orElse(null);
				RunResolution resolution = RunResolution.resolve(run,
					model.getProperties(),
					operationCallbacks, logger);

which in 7.0.0 was

RunResolution resolution = RunResolution.resolve(model.getProject(), model.getProperties()

@pkriens and @juergen-albert thoughts?

[chrisrueger]

@sad-poet I pushed PR #6381 Are you able to test if this fixes your problem?

Depending on the discussion, we could also try merging it to master, and you could use the resulting SNAPSHOT build - if that makes testing easier (and if @pkriens agrees).

[sad-poet]

@chrisrueger, thank you for the prompt feedback!

I’ve built Bndtools locally from the branch you referenced (got version 7.2.0.DEV-202412011700-gecdf229) and tested it.

I ran Bndtools two different ways: (1) in debug mode using the bndtools.gtk.linux.x86_64.bndrun file and (2) by installing features from org.bndtools.p2/generated/p2 repository to a separate Eclipse Platform instance. I imported my example project and got the same results in the two cases.

Another error message appeared on the screen:

Exception during resolution.
java.lang.NullPointerException: Cannot invoke "aQute.bnd.build.Project.exception(java.lang.Throwable, String, Object[])" because "this.project" is null
	at biz.aQute.resolve.RunResolution.reportException(RunResolution.java:417)
	at org.bndtools.core.resolve.ResolveOperation.lambda$0(ResolveOperation.java:73)
	at org.bndtools.core.resolve.ResolveOperation.coordinate(ResolveOperation.java:102)
	at org.bndtools.core.resolve.ResolveOperation.run(ResolveOperation.java:52)
	at org.bndtools.core.resolve.ResolveJob.run(ResolveJob.java:89)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

This is not very useful, because the actual exception was hidden.

The line of code that threw the exception above looks like this:

bnd/biz.aQute.resolve/src/biz/aQute/resolve/RunResolution.java

Line 417 in ecdf229

project.exception(exception, "Resolution failed unexpectedly");

I used the debugger to see what was the actual exception that could not be reported:

java.lang.RuntimeException: java.lang.NullPointerException: Cannot invoke "aQute.bnd.service.Registry.getPlugins(java.lang.Class, String[])" because "this.registry" is null
	at biz.aQute.resolve.BndrunResolveContext.init(BndrunResolveContext.java:233)
	at biz.aQute.resolve.AbstractResolveContext.initAndReport(AbstractResolveContext.java:127)
	at biz.aQute.resolve.AbstractResolveContext.getMandatoryResources(AbstractResolveContext.java:146)
	at org.apache.felix.resolver.ResolverImpl$ResolveSession.initMandatoryAndOptionalResources(ResolverImpl.java:125)
	at org.apache.felix.resolver.ResolverImpl$ResolveSession.createSession(ResolverImpl.java:102)
	at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:420)
	at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:375)
	at biz.aQute.resolve.BndResolver.resolve(BndResolver.java:32)
	at biz.aQute.resolve.ResolveProcess.resolveRequired(ResolveProcess.java:86)
	at biz.aQute.resolve.RunResolution.resolve(RunResolution.java:115)
	at org.bndtools.core.resolve.ResolveOperation.lambda$0(ResolveOperation.java:62)
	at org.bndtools.core.resolve.ResolveOperation.coordinate(ResolveOperation.java:102)
	at org.bndtools.core.resolve.ResolveOperation.run(ResolveOperation.java:52)
	at org.bndtools.core.resolve.ResolveJob.run(ResolveJob.java:89)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: java.lang.NullPointerException: Cannot invoke "aQute.bnd.service.Registry.getPlugins(java.lang.Class, String[])" because "this.registry" is null
	at biz.aQute.resolve.BndrunResolveContext.getAllRepos(BndrunResolveContext.java:412)
	at biz.aQute.resolve.BndrunResolveContext.loadRepositories(BndrunResolveContext.java:345)
	at biz.aQute.resolve.BndrunResolveContext.init(BndrunResolveContext.java:133)
	... 14 more

[chrisrueger]

@sad-poet Thanks too for your quick test. This is very helpful.
Some quick thoughts:

• It seems my "fix" fixed the NPE at the place it was happening in your initial bug report
• BUT: now it just happens later

I think it comes down to the question: Why is project null suddenly?

Note: this.registry is also the project in the Exception Caused by: java.lang.NullPointerException: Cannot invoke "aQute.bnd.service.Registry.getPlugins(java.lang.Class, String[])" because "this.registry" is null

I think we need to investigate in the code place I referenced earlier:

fbc917c#diff-a4b407ab5fd64c74fc1c5decc823f997e3ba96bc4aefda5829aa7153d52d9ba9L57-R60

Project run = model.getOwner(Project.class)
					.orElse(null);
				RunResolution resolution = RunResolution.resolve(run,
					model.getProperties(),
					operationCallbacks, logger);

which in 7.0.0 was

RunResolution resolution = RunResolution.resolve(model.getProject(), model.getProperties()

This was related to change to BndEditModel in PR #6082

Maybe in the M2E case, something is different than in the Bnd Workspace Model.
@pkriens

Update: Places to look into:

• bndtools.editor.BndEditor.loadEditModel(File, BndEditModel) and there

Processor p = workspace.readLocked(() -> workspace.findProcessor(inputFile)
				.orElseGet(() -> {
					Processor dummy = new Processor();
					dummy.setBase(inputFile.getParentFile());
					dummy.setPropertiesFile(inputFile);
					return dummy;
				}));
			model.setWorkspace(workspace);
			model.setOwner(p);

My suspicion is , that this finds a Processor which is not instanceOf Project.class and calls setOwner(p) with it.
Sorry, I haven't found time for a reproducer setup yet.

[pkriens]

I'll take a look ...

[pkriens]

The problem seems here:

bnd/bndtools.core/src/bndtools/editor/BndEditor.java

Lines 620 to 623 in abad56e

	Processor dummy = new Processor();
	dummy.setBase(inputFile.getParentFile());
	dummy.setPropertiesFile(inputFile);
	return dummy;

The Processor must be a bndrun (which is a project). Seems I made that mistake when we worked on the property inheritance. Kind of scary nobody discovered this so far.

I'll prepare a PR

[markus7017]

Has the fix already been merged, because I see the same problem with a fresh IDE install