Fix regression in Open Type Hierarchy#5255
Merged
bjhargrave merged 3 commits intobndtools:masterfrom May 19, 2022
Merged
Conversation
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Also other fixes to clean up store implementation. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
The JDT type hierarchy search does not work properly when a source folder is not-accessible following by a binary jar which is. This caused types in the jar to be missing from the hierarchy result. So we add back the `source=project` -buildpath clause option. The value `project` is the default. So saying `source=none` on a -buildpath entry, will cause Bndtools to mark the source project as discouraged to force the compiler to use the classes in the generated jar. Fixes bndtools#5250 Signed-off-by: BJ Hargrave <bj@hargrave.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JDT type hierarchy search does not work properly when a
source folder is not-accessible following by a binary jar which is.
This caused types in the jar to be missing from the hierarchy result.
So we add back the
source=project-buildpath clause option. Thevalue
projectis the default. So sayingsource=noneon a -buildpathentry, will cause Bndtools to mark the source project as discouraged
to force the compiler to use the classes in the generated jar.