maven: Use actual file name for jar file type test#5351
Merged
bjhargrave merged 1 commit intobndtools:masterfrom Aug 19, 2022
Merged
maven: Use actual file name for jar file type test#5351bjhargrave merged 1 commit intobndtools:masterfrom
bjhargrave merged 1 commit intobndtools:masterfrom
Conversation
Since we care about the file and not just the artifact object, we check the file name for ending in ".jar" (jar extension) instead of relying on the artifact reporting the "jar" type. Fixes bndtools#5349 Signed-off-by: BJ Hargrave <bj@hargrave.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we care about the file and not just the artifact object, we check
the file name for ending in ".jar" (jar extension) instead of relying
on the artifact reporting the "jar" type.
Fixes #5349