Conversation
Signed-off-by: Juergen Albert <j.albert@data-in-motion.biz> Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: Juergen Albert <j.albert@data-in-motion.biz> Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: Juergen Albert <j.albert@data-in-motion.biz> Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Closed
juergen-albert
approved these changes
Oct 4, 2022
Contributor
juergen-albert
left a comment
juergen-albert
left a comment
There was a problem hiding this comment.
LGTM! Sorry for not making my PR editable from the start. I definitelly need to make this my default. Right now I simply overlooked the checkbox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #5319 since @juergen-albert never allows edits by maintainers.
I tidied things up, removed some files that should not have been in source control and restored some fixes that were reverted.