Conversation
The problem was that there was no test cases. There actually was a loop detection. I already was incredibly surprised because I am pretty sure I wrote this code and forgetting to check cycles is even beneath me.However, I'd forgotten to add a return after the error message ... So the code continued forever to include the same file anyway although dutifully reporting it. Fixes #5336 Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
--- Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
worked fine Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
Member
Author
|
Slight apology for blamed windows for my own stupidity. Pushed to my fork instead of origin while trying to be a nice git citizen. No good deed goes unpunished :-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that there was no test cases. There
actually was a loop detection. I already was incredibly
surprised because I am pretty sure I wrote this code
and forgetting to check cycles is even beneath me.However,
I'd forgotten to add a return after the error message ...
So the code continued forever to include the same
file anyway although dutifully reporting it.
Fixes #5336
Signed-off-by: Peter Kriens Peter.Kriens@aqute.biz