Skip to content

♻ Make list validator more general #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hf-aschloegl merged 1 commit into from
Dec 21, 2021
Merged

♻ Make list validator more general #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/bo4e/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ def check_list_length_is_one_or_two(instance, attribute, value):
Check if list length is one or two.
So far only used in StandorteigenschaftenGas.
"""
if len(instance.netzkontonummern) == 0:
raise ValueError("Netzkontonummern must not be empty.")
if len(instance.netzkontonummern) > 2:
raise ValueError("Maximum number of Netzkontonummern is 2.")
if len(value) == 0:
raise ValueError(f"{attribute.name} must not be empty.")
if len(value) > 2:
raise ValueError(f"Maximum number of {attribute.name} is 2.")


# pylint:disable=too-few-public-methods
Expand Down
4 changes: 2 additions & 2 deletions tests/test_standorteigenschaftengas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ def test_standorteigenschaftengas_missing_required_attributes(self):
[
pytest.param(
[],
"Netzkontonummern must not be empty.",
"netzkontonummern must not be empty.",
),
pytest.param(
["1", "2", "3"],
"Maximum number of Netzkontonummern is 2.",
"Maximum number of netzkontonummern is 2.",
),
],
)
Expand Down