Implement BO Lastgang + BO LastgangKompakt#295
Merged
Conversation
hf-kklein
changed the title
hf-aschloegl
approved these changes
Jan 17, 2022
|
|
||
| #: Marktlokation oder Messlokation | ||
| lokationstyp: str = attr.ib(validator=attr.validators.instance_of(Lokationstyp)) | ||
| # todo: implement a lokations-id + lokationstyp cross check (such that lokationstyp malo checks for valid malo id) |
Collaborator
There was a problem hiding this comment.
Gibt es dafür schon ein Issue?
| # optional attributes | ||
| #: Versionsnummer des Lastgangs | ||
| version: Optional[str] = attr.ib(default=None, validator=attr.validators.optional(attr.validators.instance_of(str))) | ||
| #: Die OBIS-Kennzahl für den Wert, die festlegt, welche Größe mit dem Stand gemeldet wird, z.B. '1-0:1.8.1' |
Collaborator
There was a problem hiding this comment.
Woher kommt denn dieser Docstring? :D
In der Doku hab ich diesen gefunden:
Suggested change
| #: Die OBIS-Kennzahl für den Wert, die festlegt, welche Größe mit dem Stand gemeldet wird, z.B. '1-0:1.8.1' | |
| #: Genormte OBIS-Kennzahl zur Kennzeichnung der Messgröße |
Contributor
Author
There was a problem hiding this comment.
das hatte ich glaube ich aus dem anderen lastgang kopiert.
Collaborator
There was a problem hiding this comment.
Hab ich extra geschaut, das ist bei beiden Lastgängen der Kommentar. Aber vllt. einfach von woanders wo eine OBIS-Kennzahl genutzt wird.
|
|
||
| #: Angabe des Rasters innerhalb aller Tagesvektoren dieses Lastgangs | ||
| zeitintervall: Zeitintervall = attr.ib(validator=attr.validators.instance_of(Zeitintervall)) | ||
| # todo: implement a cross check that this zeitintervall is actually the one used in tagesvektoren |
Co-authored-by: Annika <73470827+hf-aschloegl@users.noreply.github.com>
Co-authored-by: Annika <73470827+hf-aschloegl@users.noreply.github.com>
Co-authored-by: Annika <73470827+hf-aschloegl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188
Fixes #197