Implement BO PreisblattKonzessionsabgabe#326
Merged
Conversation
hf-krechan
approved these changes
Jan 21, 2022
Collaborator
hf-krechan
left a comment
hf-krechan
left a comment
There was a problem hiding this comment.
Sweet work. One small question regarding the marshmallow schema.
| Schema for de-/serialization of PreisblattKonzessionsabgabe | ||
| """ | ||
|
|
||
| class_name = PreisblattKonzessionsabgabe # type:ignore[assignment] |
Collaborator
There was a problem hiding this comment.
Is this a new approach how to deserialize into the right class?
Contributor
Author
There was a problem hiding this comment.
it's not new, just new born ;)
yep, but I didn't manage to override it so that mypy accepts it too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #203