Conversation
Closed
hf-fvesely
requested changes
Jan 23, 2022
| ) | ||
| # todo: fix inconsistency with regionaltarif https://github.com/Hochfrequenz/BO4E-python/issues/346 | ||
| #: Die Bedingungen und Einschränkungen unter denen ein Tarif angewendet werden kann | ||
| tarifeinschraenkung: Optional[Tarifeinschraenkung] = attr.ib( |
Contributor
There was a problem hiding this comment.
Suggested change
| tarifeinschraenkung: Optional[Tarifeinschraenkung] = attr.ib( | |
| tarifeinschraenkungen: Optional[Tarifeinschraenkung] = attr.ib( |
Contributor
Author
There was a problem hiding this comment.
Das ist absicht. Da ist die bestehende Doku glaube ich Quatsch. Wir sollten nichts als Plural benennen, was kein Plural ist.
| # optional attributes | ||
| tarif_auf_abschlaege = fields.List(fields.Nested(AufAbschlagRegionalSchema), allow_none=True) | ||
| preisgarantie = fields.Nested(PreisgarantieSchema, allow_none=True) | ||
| tarifeinschraenkung = fields.Nested(TarifeinschraenkungSchema, allow_none=True) |
Contributor
There was a problem hiding this comment.
Suggested change
| tarifeinschraenkung = fields.Nested(TarifeinschraenkungSchema, allow_none=True) | |
| tarifeinschraenkungen = fields.Nested(TarifeinschraenkungSchema, allow_none=True) |
| tarif_auf_abschlaege=[example_aufabschlagregional], | ||
| tarifpreise=[example_tarifpreispositionproort], | ||
| preisgarantie=example_preisgarantie, | ||
| tarifeinschraenkung=example_tarifeinschraenkung, |
Contributor
There was a problem hiding this comment.
Suggested change
| tarifeinschraenkung=example_tarifeinschraenkung, | |
| tarifeinschraenkungen=example_tarifeinschraenkung, |
Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com>
Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com>
Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com>
Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com>
Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com>
Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com>
Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com>
Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com>
Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com>
Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com>
Co-authored-by: Franziska <73471037+hf-fvesely@users.noreply.github.com>
hf-fvesely
approved these changes
Jan 23, 2022
Contributor
Author
|
oh man @hf-fvesely : wie lange hast du dich abgequält diese 20(?) änderungen in einzelne suggestions zu verpacken 😀 nächstes mal aber ruhig einfach drüber commiten oder einfach einen eigenen PR aufmachen ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #211
review #342 first