Conversation
hf-kklein
approved these changes
Jun 8, 2022
Contributor
hf-kklein
left a comment
There was a problem hiding this comment.
warum braucht es das requirements file? und funktioniert das dann auch mit den requirements (in den tests), die nicht in der rqeuirements.txt stehen?
Collaborator
Author
|
Die Dokumentation von isort sagte, dass man die requirements.txt angeben soll. dann müssten wir ggf. unser tox setup dahingehend anpassen, dass wir pro Environment eigene requirements erzeugen. |
Collaborator
Author
|
Würde es erstmal so versuchen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR should solve the issue #290 by introducing isort GH action
I am not totally sure, if
isortwill only check the import order or if it also makes some changes.I just used the example from the isort-action repository.