Skip to content

Add isort to GH action#381

Merged
hf-kklein merged 4 commits intomainfrom
add-isort-gh-action
Jun 17, 2022
Merged

Add isort to GH action#381
hf-kklein merged 4 commits intomainfrom
add-isort-gh-action

Conversation

@hf-krechan
Copy link
Copy Markdown
Collaborator

@hf-krechan hf-krechan commented Jun 8, 2022

this PR should solve the issue #290 by introducing isort GH action

I am not totally sure, if isort will only check the import order or if it also makes some changes.
I just used the example from the isort-action repository.

@hf-krechan hf-krechan requested a review from hf-kklein June 8, 2022 08:18
Copy link
Copy Markdown
Contributor

@hf-kklein hf-kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warum braucht es das requirements file? und funktioniert das dann auch mit den requirements (in den tests), die nicht in der rqeuirements.txt stehen?

@hf-krechan
Copy link
Copy Markdown
Collaborator Author

hf-krechan commented Jun 8, 2022

Die Dokumentation von isort sagte, dass man die requirements.txt angeben soll.
Man kann auch mehrere requirements.txt files angeben.

dann müssten wir ggf. unser tox setup dahingehend anpassen, dass wir pro Environment eigene requirements erzeugen.
Was auch gehen würde.
Dann gäbe es requirements-tests.txt, requirements-linting.txt und requirements-coverage.txt

@hf-krechan hf-krechan linked an issue Jun 8, 2022 that may be closed by this pull request
@hf-krechan
Copy link
Copy Markdown
Collaborator Author

Würde es erstmal so versuchen.
Mein pre-commit hook wird sich in Zukunft schon melden, falls jemand ohne isort commited hat.
Dann kann ich es mir immer noch anschauen

@hf-kklein hf-kklein merged commit 8afe110 into main Jun 17, 2022
@hf-kklein hf-kklein deleted the add-isort-gh-action branch June 17, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write a GH Action to enforce isort

2 participants