🐍 Add Pydantic extra="allow" to Geschaeftsobjekt and COM base classes#439
Merged
🐍 Add Pydantic extra="allow" to Geschaeftsobjekt and COM base classes#439
extra="allow" to Geschaeftsobjekt and COM base classes#439Conversation
This allows to deserialized unmatched properties
hf-krechan
approved these changes
Dec 14, 2022
Comment on lines
+71
to
+76
| er = ExterneReferenz(ex_ref_name="foo.bar", ex_ref_wert="12345") | ||
| er_json: Dict[str, Any] = er.dict() | ||
| er_json["additional_key"] = "additional_value" | ||
| deserialized_er: ExterneReferenz = ExterneReferenz.parse_obj(er_json) | ||
| assert isinstance(deserialized_er, ExterneReferenz) | ||
| assert deserialized_er.additional_key == "additional_value" # type:ignore[attr-defined] |
Collaborator
There was a problem hiding this comment.
nur für mein Verständnis, das hätte auch ohne das extra = "allow" geklappt oder?
Contributor
Author
There was a problem hiding this comment.
Nein, genau dafür is extra="allow" da. Siehe
def test_extension_data(self) -> None: """ tests the behaviour of the json extension data (`extra="allow"`) """ er = ExterneReferenz(ex_ref_name="foo.bar", ex_ref_wert="12345") er_json: Dict[str, Any] = er.dict() er_json["additional_key"] = "additional_value" deserialized_er: ExterneReferenz = ExterneReferenz.parse_obj(er_json) assert isinstance(deserialized_er, ExterneReferenz) assert deserialized_er.additional_key == "additional_value" # type:ignore[attr-defined]E AttributeError: 'ExterneReferenz' object has no attribute 'additional_key'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to deserialized unmatched properties