Skip to content

Replaces py imports in tests suit with pathlib #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hf-kklein merged 2 commits into from
May 3, 2023
Merged

Replaces py imports in tests suit with pathlib #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43e91fd
switch to pathlib
mj0nez May 2, 2023
3b8e2ec
formatting
mj0nez May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_adresse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from pathlib import Path
from typing import Dict, Optional

import pytest
from py._path.local import LocalPath # type:ignore[import]
from pydantic import ValidationError

from bo4e.com.adresse import Adresse
Expand Down Expand Up @@ -120,7 +120,7 @@ def test_deserialization(self) -> None:
assert a.landescode is Landescode.AT # type: ignore[attr-defined]

@pytest.mark.datafiles("./tests/test_data/test_data_adresse/test_data_adresse_missing_plz.json")
def test_missing_required_attribute(self, datafiles: LocalPath) -> None:
def test_missing_required_attribute(self, datafiles: Path) -> None:
"""
Test for getting an error message if a required attribute is missing
"""
Expand Down
4 changes: 2 additions & 2 deletions tests/test_geschaeftspartner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import json
from pathlib import Path

import pytest
from py._path.local import LocalPath # type:ignore[import]
from pydantic import ValidationError

from bo4e.bo.geschaeftspartner import Geschaeftspartner
Expand All @@ -15,7 +15,7 @@

class TestGeschaeftspartner:
@pytest.mark.datafiles("./tests/test_data/test_data_adresse/test_data_adresse_only_required_fields.json")
def test_serializable(self, datafiles: LocalPath) -> None:
def test_serializable(self, datafiles: Path) -> None:
with open(datafiles / "test_data_adresse_only_required_fields.json", encoding="utf-8") as json_file:
address_test_data = json.load(json_file)

Expand Down