Skip to content

(chore) Add typeguard to docs-dependencies used by readthedocs#489

Merged
hf-kklein merged 1 commit intomainfrom
deps
Jul 20, 2023
Merged

(chore) Add typeguard to docs-dependencies used by readthedocs#489
hf-kklein merged 1 commit intomainfrom
deps

Conversation

@hf-kklein
Copy link
Copy Markdown
Contributor

@hf-kklein hf-kklein commented Jul 20, 2023

@hf-kklein hf-kklein changed the title Add typeguard to docs-dependencies used by readthedocs (chore) Add typeguard to docs-dependencies used by readthedocs Jul 20, 2023
@hf-kklein hf-kklein marked this pull request as ready for review July 20, 2023 11:12
Copy link
Copy Markdown
Collaborator

@lord-haffi lord-haffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wenn es da schon ein requirements file gibt, nur für die docs, sollte man das dann nicht in der tox.ini importieren? Dann sparen wir uns die Dopplung.

@hf-kklein
Copy link
Copy Markdown
Contributor Author

Ja, das ist das Thema des verlinkten issues. Wir sollten das auch Pinnen damit es reproduzierbar bleibt

@hf-kklein hf-kklein merged commit 3539eb1 into main Jul 20, 2023
@hf-kklein hf-kklein deleted the deps branch July 20, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants