CI: Replace formatting action with pre-commit#531
Merged
hf-krechan merged 8 commits intobo4e:mainfrom Sep 26, 2023
Merged
Conversation
Contributor
|
Hi @hf-krechan could you please Check if this meets our requirements? Especially if we still have the Server Side Checks |
hf-krechan
approved these changes
Sep 25, 2023
Collaborator
hf-krechan
left a comment
There was a problem hiding this comment.
Nice idea. Thank you very much for your support and PRs :)
Collaborator
yes I will have a look at it |
Contributor
|
@hf-krechan ich glaube du müsstest noch die branch-protection für main entsprechend anpassen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #530
This PR replaces the current action with a pre-commit-action to adjust this.
The output would change marginal - e.g. for a successfull run it would look like:
and for a faild one:
Additional benefits
This change would also pin the versions of black & isort and sync them between CI and development environments (as proposed in #474).