Skip to content

📌 created files dev_requirements to pin CI Dependencies#536

Merged
DeltaDaniel merged 5 commits intomainfrom
DDB/issue-474-CI-Dependencies
Sep 25, 2023
Merged

📌 created files dev_requirements to pin CI Dependencies#536
DeltaDaniel merged 5 commits intomainfrom
DDB/issue-474-CI-Dependencies

Conversation

@DeltaDaniel
Copy link
Copy Markdown
Collaborator

No description provided.

tox.ini Outdated
basepython = python3.10
skip_install = true
deps = -r requirements/tests.txt
deps = -r requirements/tests.txt #todo: depracted?
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
deps = -r requirements/tests.txt #todo: depracted?
deps = -r requirements/requirements-tests.txt #todo: depracted?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 102 to 103
setuptools
setuptools-scm
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warum sind setuptools nicht teil der requirements-packaging?

Copy link
Copy Markdown
Collaborator Author

@DeltaDaniel DeltaDaniel Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip-compile returns

#The following packages are considered to be unsafe in a requirements file:
# setuptools

(cf. jazzband/pip-tools#522 )

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, kommt dann mit dem umstieg auf hatchling eh weg.

DeltaDaniel and others added 2 commits September 25, 2023 15:50
Co-authored-by: konstantin <konstantin.klein@hochfrequenz.de>
tox.ini Outdated
[testenv:linting]
deps =
-rrequirements.txt
#-r requirements.txt
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wieso braucht es die requiements nicht mehr fürs linting?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, übersehen. 4ead9eb

@hf-kklein hf-kklein linked an issue Sep 25, 2023 that may be closed by this pull request
@hf-kklein hf-kklein marked this pull request as ready for review September 25, 2023 14:08
@DeltaDaniel DeltaDaniel merged commit 245df53 into main Sep 25, 2023
@DeltaDaniel DeltaDaniel deleted the DDB/issue-474-CI-Dependencies branch September 25, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin CI Dependencies

2 participants