Skip to content

📝🎨update enum member documentation to sphinx compatible format#81

Merged
hf-kklein merged 3 commits intodevelopfrom
change_documentation_of_all_enums
Dec 1, 2021
Merged

📝🎨update enum member documentation to sphinx compatible format#81
hf-kklein merged 3 commits intodevelopfrom
change_documentation_of_all_enums

Conversation

@hf-kklein
Copy link
Copy Markdown
Contributor

Repeates the steps from #78 for all enum (member)s

@hf-kklein hf-kklein self-assigned this Nov 22, 2021
@hf-kklein hf-kklein requested a review from hf-krechan November 22, 2021 11:52
@hf-kklein hf-kklein marked this pull request as ready for review November 22, 2021 11:52
Copy link
Copy Markdown
Collaborator

@hf-krechan hf-krechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the question what is the purpose of : and if it's important, one enum entry is missing it.

.. code-block:: Shell

"$wert": "$wert", # $bedeutung
"$wert": "$wert", #: $bedeutung
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of the :?

BILANZKREISKOORDINATOR = "BILANZKREISKOORDINATOR" #: Bilanzkreiskoordinator
BILANZKREISVERANTWORTLICHER = "BILANZKREISVERANTWORTLICHER" #: Bilanzkreisverantwortlicher
DATENFORMATE_ZERTIFIKATE_VERSCHLUESSELUNGEN = (
"DATENFORMATE_ZERTIFIKATE_VERSCHLUESSELUNGEN" # Datenformate, Zertifikate, Verschlüsselungen
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The : is here missing, isn't it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably my regex search and replace failed for those entries... maybe because they span multiple lines.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hf-kklein
Copy link
Copy Markdown
Contributor Author

Just the question what is the purpose of :

see #78 it's described there including minimal examples (tl;dr: doc entries for enum members with trailing #: do have a sphinx docstring, without don't)

Copy link
Copy Markdown
Collaborator

@hf-krechan hf-krechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go

@hf-kklein hf-kklein merged commit ed93e6c into develop Dec 1, 2021
@hf-kklein hf-kklein deleted the change_documentation_of_all_enums branch December 1, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants