fix(CI): Fixes an error in version check inside release workflow#978
Merged
lord-haffi merged 2 commits intomainfrom Mar 21, 2025
Merged
fix(CI): Fixes an error in version check inside release workflow#978lord-haffi merged 2 commits intomainfrom
lord-haffi merged 2 commits intomainfrom
Conversation
hf-krechan
approved these changes
Mar 21, 2025
| return getattr(self, attr) < getattr(other, attr) | ||
| if self.candidate != other.candidate: | ||
| return self.candidate is not None and (other.candidate is None or self.candidate < other.candidate) | ||
| return False # self == other |
Collaborator
There was a problem hiding this comment.
wofür ist der Kommentar?
Collaborator
Author
There was a problem hiding this comment.
Um zu verdeutlichen, dass wir an der Stelle des Codes wissen, dass die Versionen gleich sind und dementsprechend __lt__ ein False zurückgeben muss. Ist der Kommentar nicht sprechend? ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script evaluated
202401.10.10 > 202501.1.1before. This PR fixes the issue for now. Note, that this will be replaced by theBO4E-CLIin the future. The fix is more or less copied from there.