Revert multiline toggle-comment behavior#591
Merged
bobbylight merged 1 commit intomasterfrom Dec 21, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #591 +/- ##
============================================
- Coverage 80.40% 80.40% -0.01%
+ Complexity 7793 7792 -1
============================================
Files 178 178
Lines 30261 30261
Branches 3914 3913 -1
============================================
- Hits 24332 24330 -2
- Misses 4255 4257 +2
Partials 1674 1674 ☔ View full report in Codecov by Sentry. |
Owner
Author
|
This is in the latest 3.5.4-SNAPSHOT on Sonatype. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior fix for #570 (f0d8326) accidentally broke behavior when multiple lines are selected. Specifically, in that case we should continue to toggle the "commented out" state for all lines uniformly, based on whether they are all currently commented out or not. This is needed to uniformly comment out blocks of code even if they have line comments in them.
This PR reverts to the prior behavior there, but keeps the prior fix's behavior change for toggling single-line comments (i.e. leading whitespace is ignored in the check). Unit tests have been thoroughly improved to cover all cases.