Skip to content

Fix #593: Folded code preview should use proper default FG color#598

Merged
bobbylight merged 1 commit intomasterfrom
fix-593-default-fg-font-color-not-used-in-code-fold-previews
Feb 6, 2025
Merged

Fix #593: Folded code preview should use proper default FG color#598
bobbylight merged 1 commit intomasterfrom
fix-593-default-fg-font-color-not-used-in-code-fold-previews

Conversation

@bobbylight
Copy link
Owner

@bobbylight bobbylight commented Feb 6, 2025

Fix for #593. The preview tooltips displayed by collapsed folds should follow RSTA's logic, and fall back to the text area's foreground color for any token types without a specific FG color, rather than black.

Before After
image image

@bobbylight bobbylight force-pushed the fix-593-default-fg-font-color-not-used-in-code-fold-previews branch 2 times, most recently from 24dc914 to ef4f167 Compare February 6, 2025 23:17
@bobbylight bobbylight self-assigned this Feb 6, 2025
@bobbylight bobbylight added this to the 3.5.4 milestone Feb 6, 2025
@bobbylight bobbylight force-pushed the fix-593-default-fg-font-color-not-used-in-code-fold-previews branch from ef4f167 to 798874a Compare February 6, 2025 23:25
@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.50%. Comparing base (54a2d04) to head (798874a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #598      +/-   ##
============================================
+ Coverage     80.49%   80.50%   +0.01%     
+ Complexity     7808     7806       -2     
============================================
  Files           178      178              
  Lines         30263    30253      -10     
  Branches       3914     3912       -2     
============================================
- Hits          24361    24356       -5     
+ Misses         4235     4232       -3     
+ Partials       1667     1665       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobbylight bobbylight marked this pull request as ready for review February 6, 2025 23:30
@bobbylight bobbylight merged commit 913cd4d into master Feb 6, 2025
7 checks passed
@bobbylight bobbylight deleted the fix-593-default-fg-font-color-not-used-in-code-fold-previews branch February 6, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant