Specialize range_const_iterator_helper for std::span#122
Open
ecatmur wants to merge 7 commits intoboostorg:developfrom
Open
Specialize range_const_iterator_helper for std::span#122ecatmur wants to merge 7 commits intoboostorg:developfrom
ecatmur wants to merge 7 commits intoboostorg:developfrom
Conversation
std::span does not have const_iterator member type, so this fails:
#include <span>
#include <boost/range/iterator.hpp>
using X = boost::range_iterator<std::span<int, 3> const>::type;
Contributor
|
FYI: it was caused by http://wg21.link/lwg3320 resolution and a subject of P2276. |
Contributor
|
any update on this? |
Member
|
I think we need to fix up the CI for testing this i.e. Appveyor and Github Actions (Travis is dead to us now). On top of that, this PR will need unit tests. |
iterator<span const> == iterator<span>
Author
Thanks, yeah this is tricky - and also I've taken the approach that we want the simplest possible solution that could work, which for now is ignoring |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::span does not have const_iterator member type, so this fails:
also
boost::begin()andboost::end()fail, and anything that calls them (e.g.boost::size()).Demo.
I'm using 201902 as the feature test value on the basis that an implementation may have removed
const_iterator(fixing LWG 3320) but not yet applied P1976R2 which updates the feature test to 202002L.