Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

feat: liked playlist #52

Merged
ooliver1 merged 9 commits into from
Nov 20, 2022
Merged

feat: liked playlist #52

ooliver1 merged 9 commits into from
Nov 20, 2022

Conversation

@ooliver1
Copy link
Member

@ooliver1 ooliver1 commented Nov 18, 2022

Resolves #14

@ooliver1 ooliver1 added this to the 1.1 milestone Nov 18, 2022
@ooliver1 ooliver1 added Frontend Client side New command New command to be made labels Nov 18, 2022
@ooliver1 ooliver1 requested a review from Arnav717 November 18, 2022 20:10
@Arnav717
Copy link
Member

Arnav717 commented Nov 20, 2022

we can also add dynamic button like if already in the liked list and different colour..

Arnav717
Arnav717 suggested changes Nov 20, 2022
View reviewed changes
Copy link
Member

@Arnav717 Arnav717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also do not use utube links

@ooliver1
Copy link
Member Author

ooliver1 commented Nov 20, 2022

we can also add dynamic button like if already in the liked list and different colour..

That's per user, but having it be static means it is the same for every user

@ooliver1
Copy link
Member Author

ooliver1 commented Nov 20, 2022

also do not use utube links

This is the same code as the queue

@Arnav717
Copy link
Member

Arnav717 commented Nov 20, 2022

we can also add dynamic button like if already in the liked list and different colour..

That's per user, but having it be static means it is the same for every user

oh ye thats also true

@Arnav717
Copy link
Member

Arnav717 commented Nov 20, 2022

also do not use utube links

This is the same code as the queue

going to change that

@Arnav717 Arnav717 self-requested a review November 20, 2022 11:15
@ooliver1 ooliver1 merged commit bf2aed4 into main Nov 20, 2022
@ooliver1 ooliver1 deleted the feat/like-playlist branch November 20, 2022 14:22
Arnav717 added a commit that referenced this pull request Nov 21, 2022
@Arnav717
feat: liked playlist (#52)
c20221d 
* feat: get /liked add working

* feat: order by date added

* feat(playlists): /liked remove

* refactor(playlists): add err for no liked songs

* feat(playlists): /like play

* fix: make thing do work

* fix: add unused inter arg

* fix: modify init.sql

* added odesli + check for song if already in

Co-authored-by: Arnavop <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Arnav717 Arnav717 Arnav717 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Frontend Client side New command New command to be made

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

Like song

3 participants

@ooliver1 @Arnav717