Hypnotoad: more flexible transitions in nonorthogonal grid generation #1596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the nonorthogonal grid generator changed the radial grid direction from the boundary vector at one end of a region, to the normal to flux surfaces half way through the region, and then to the other boundary vector at the far end of the region. This could cause issues, for example if the line normal to the flux surfaces half way through the region intersects with one of the region boundaries. Instead, use both vectors with separate weights. The weights are now set to decay with the power 2.7 instead of 1.35, because the parameter under the power now increases/decreases half as quickly (but extends the full length of the region, not just half).
bendudson
approved these changes
Feb 21, 2019
Contributor
bendudson
left a comment
bendudson
left a comment
There was a problem hiding this comment.
Sorry, my fault. Thanks @johnomotani
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1594 should have been changed to merge into
nextas #1593 was merged first. New PR to merge the branch intonextnow. Sorry for the confusion!