Reintroduce removed copy function marked deprecated #2891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This gives dependend codes more time to adopt.
dschwoerer
force-pushed
the
reintroduce-implicit-copy
branch
from
6e7bdf3 to
2c01f10
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
bendudson
approved these changes
Mar 21, 2024
Contributor
bendudson
left a comment
bendudson
left a comment
There was a problem hiding this comment.
Thanks @dschwoerer ! This is a good idea that I didn't think of. I guess this is why we have a next branch :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives dependent codes more time to adopt.
It gives a warning now, with the intent to revert later to get the error again.
We can revert this commit later, to finally remove it.
Sorry that I did not think of this earlier, but it is not yet released, so might be still be useful ...