-
Notifications
You must be signed in to change notification settings - Fork 21
Energy transfer diagnostics #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bendudson
wants to merge
18
commits into
master
Choose a base branch
from
energy-diagnostics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saves total energy sink and gamma heat transmission factors.
The coefficients are not time dependent, so always save as time independent fields, since this does not take much storage space.
If parallel flow is not present, then flow_ylow would not be initialised. This could then cause an operation on an empty field later.
Only add a time_dimension attribute if the source is time dependent. This saves storage space, and makes clear in the output whether the source was time dependent.
Energy exchange between ExB flow and other forms. Hopefully helpful in understanding the flow of energy through the system.
If `diagnose = true`, save energy transfer and advection channels.
phi_pol is only calculated if polarisation drift advection is enabled.
- Can't have "/" in the variable name - Use getNonFinal when retrieving the value so the value can be modified.
Output energy diagnostics.
Energy transfer between species.
Energy transfer channels.
Energy transfer channels
Energy transfer channels
Energy transfer diagnostics
Heat flux diagnostics
Numerical energy dissipation
Collaborator
|
This looks great! One thing I noticed is that the diagnostic nomenclature is different than existing, e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many optional diagnostic outputs, saving energy transfer channels for post-processing.
Not ready for merging: Need to consolidate sheath boundary diagnostics.