Perform topological sort to order components #428
+991
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is nearly done. Remaining tasks:
|
cmacmackin
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 29.52% 30.51% +0.98%
==========================================
Files 94 94
Lines 8768 8903 +135
Branches 1228 1257 +29
==========================================
+ Hits 2589 2717 +128
- Misses 5914 5916 +2
- Partials 265 270 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmacmackin
force-pushed
the
cmacmackin/topological_sort_components
branch
from
a75b2ce to
8d049e2
Compare
cmacmackin
changed the title
This was referenced Dec 8, 2025
cmacmackin
force-pushed
the
cmacmackin/topological_sort_components
branch
from
c31490e to
e650c1c
Compare
cmacmackin
force-pushed
the
cmacmackin/topological_sort_components
branch
from
e650c1c to
9dbeed5
Compare
cmacmackin
force-pushed
the
cmacmackin/topological_sort_components
branch
from
9dbeed5 to
04a8977
Compare
Note that components still aren't setting up any permissions, so there would be runtime errors when executing the transform methods. Furthermore, there are some missing methods I realise I need for GuardedOptions. The unit tests are also failing to compile, although I don't understand what the problem is for them, yet.
ZedThree
force-pushed
the
cmacmackin/topological_sort_components
branch
from
04a8977 to
8fc17e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the access control information introduced in #421, this PR makes it possible for Hermes-3 to work out the order of components at run-time. This will make things far simpler and more robust for users. It will also fail faster if there is an unsatisfiable or circular dependency.
Closes #384.