[CLOSED] Update strings.js

[core-ai-bot]

Issue by ghost
Friday Apr 18, 2014 at 18:11 GMT
Originally opened as adobe/brackets#7565

---

---

ghost included the following code: https://github.com/adobe/brackets/pull/7565/commits

[core-ai-bot]

Comment by RaymondLim
Monday Apr 21, 2014 at 01:42 GMT

---

@kvarel Thanks for making changes that I suggested in #7532. This is a new pull request because you're making changes in a new branch kvarel:patch-16 instead of kvarel:patch-15 branch. Can you switch back to kvarel:patch-15 and make a new commit in that branch? Then your changes will go into that pull request and we can close this one.

Before you make a new commit, you also need to make some other changes too. When you made changes that I mentioned in my comment, you need to adjust line numbers since all line numbers that I mentioned are based on the previous version of the file. If you insert a line, then all line numbers larger than that line need to add one.

[core-ai-bot]

Comment by RaymondLim
Tuesday May 06, 2014 at 04:09 GMT

---

@kvarel
Do you need help with committing to the other pull request?

[core-ai-bot]

Comment by njx
Wednesday May 14, 2014 at 18:56 GMT

---

@RaymondLim I think in general@kvarel is just editing through the web interface, so we probably need to go ahead and do the fixups ourselves (that's what we've done in the past).

[core-ai-bot]

Comment by njx
Wednesday May 14, 2014 at 19:07 GMT

---

Marking medium prioritiy since this is is a significant update.

[core-ai-bot]

Comment by redmunds
Wednesday May 14, 2014 at 21:06 GMT

---

@njx@RaymondLim When working with the Croatian contribution, I learned how to do it through directly editing on github.com so I could instruct contributor what to do. I updated nls/README.md in pull request adobe/brackets#7840 with the info, in case it helps here.

[core-ai-bot]

Comment by RaymondLim
Thursday May 29, 2014 at 07:19 GMT

---

Merging now so that I can fix it up the necessary changes.