Added support for multiple screenshot file formats#341
Merged
alessandrofelder merged 5 commits intomainfrom Apr 25, 2024
Merged
Added support for multiple screenshot file formats#341alessandrofelder merged 5 commits intomainfrom
alessandrofelder merged 5 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
=======================================
Coverage 86.47% 86.47%
=======================================
Files 27 27
Lines 1220 1220
=======================================
Hits 1055 1055
Misses 165 165 ☔ View full report in Codecov by Sentry. |
…nrender into screenshot-types Merge remote
alessandrofelder
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
Currently we only support saving screenshots as
.png.vedoseems to support.pdf,.eps,.jpg, and.svg. I don't see why we couldn't as well!What does this PR do?
Adds a check to make sure the suffix of the file name is supported before passing it back to
vedo. If there's no suffix, or it's not supported it just saves it as a.png.References
Closes #340
How has this PR been tested?
Tested locally
Is this a breaking change?
No
Does this PR require an update to the documentation?
Yes, need to document the supported file formats. There are seems to be some weird behaviour when saving as
.epsor.svgwhere they're written as.eps.gzor.svg.gzand have to be uncompressed first.Checklist: