Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
==========================================
- Coverage 86.71% 86.51% -0.20%
==========================================
Files 27 27
Lines 1219 1231 +12
==========================================
+ Hits 1057 1065 +8
- Misses 162 166 +4 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Tests seem to be failing due to the fact that |
adamltyson
approved these changes
Oct 23, 2024
Member
adamltyson
left a comment
adamltyson
left a comment
There was a problem hiding this comment.
LGTM, just one tiny comment.
brainrender/actors/neurons.py
Outdated
| :param color: str, | ||
| :param neuron_radius: float, radius of axon/dendrites | ||
| :param soma_radius: float, radius of soma | ||
| :param invert_dims: bool, invert dimensions of neuron |
Member
There was a problem hiding this comment.
Could this docstring be expanded? It's not immediately obvious what "inverting dimensions" means.
Member
Author
There was a problem hiding this comment.
Updated! Hopefully, that's a bit clearer.
adamltyson
approved these changes
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
The invert_dim parameter for loading data into
Neuronactors was hard coded to beTrue.What does this PR do?
Exposes the
invert_dimparameter in theNeuronconstructor, setting the default to beTrueReferences
#181
How has this PR been tested?
Visual inspection, all existing tests pass.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: