Conversation
|
@breakthestatic |
|
Thank you, found JS file in dist |
|
@bramkragten, just wanted to ping you, as someone in the forums was asking if this project was dead. Getting up-to-date with the underlying library could definitely help in that regard. |
|
Hey @bramkragten, annual ping - any chance this could be merged? I've been running my fork for over a year now without issue. Just bumped to most current version of swiper as of 2024-10-22. There were no breaking changes from v10 to v 11. Also bumped a few additional dependencies to resolve some audit complaints. |
|
Just tried using this and it fixed the issue I was having. Unfortunately, it looks like no parameters I have set are working anymore. Did the syntax change or something? I just uploaded your swipe-card.js file to HASS for installation |
|
Hey @NoahJamesTech, looks like there were some issues with the imports that caused the extra, individual swiper modules to not be bundled as part of the build. I only use "core" swiper params so I didn't notice it during the latest upgrade from 10 to 11. Please take a look again. The latest commit should contain all the extra modules now. Thanks for the heads up as well! |
|
@breakthestatic Thank you so much! In my testing it still doesn't work though :(. The card loads correctly, but I tried swiping and it doesn't seem to do anything, the parameters also don't seem to be making any difference. There's a possibility I'm using it wrong, but think there might be something not quite right? |
|
That fixed it! |
|
@NoahJamesTech, Heh, beat me to it. Sorry for the weird build issue, but glad it's resolved! |
Updated the Swiper library to a much more recent version.
I was specifically having an issue with shadow DOM targeting (for the
noSwipingSelector) that was fixed somewhere in v8 (used deprecated/non-standardevent.pathinstead ofevent.composedPath()).There's definitely potential that this introduces breaking changes for existing swipe-card users, as the underlying Swiper API may have changed; I didn't go through all the changes from v6 to v10...) However, it would make this component more in sync with the linked Swiper documentation, etc.
In addition to bumping Swiper to the most current version, I also bumped two other dependencies to resolve some security issues.
If you don't want to move to a new version, I totally understand. I just figured I'd offer this, as I've been using it locally for a while.