[iOS] [AI Chat] Support associating open tabs #32737
Open
+178
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehickinson
added
CI/skip-android
Contributor
📋 Code Owners Summary12 file(s) changed, 12 with assigned owners 1 team(s) affected: Owners and Their Files
|
fallaciousreasoning
approved these changes
Dec 8, 2025
Contributor
fallaciousreasoning
left a comment
fallaciousreasoning
left a comment
There was a problem hiding this comment.
I think this LGTM but definitely get someone who knows Swift to have a look 😄
One thing - I think we should just provide no tabs in private mode.
ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+TabManagerDelegate.swift
Outdated
Show resolved
Hide resolved
kylehickinson
commented
Dec 8, 2025
| ProfileIOS::FromBrowserState(self.webState->GetBrowserState()); | ||
| ai_chat::TabDataWebStateObserver::CreateForWebState( | ||
| self.webState, | ||
| CHECK_DEREF(ai_chat::TabTrackerServiceFactory::GetForProfile(profile))); |
Collaborator
Author
There was a problem hiding this comment.
Actually should probably get the service above and only create the TabDataWebStateObserver if the service is non-nil
This allows associating specific tabs that have already been loaded by referencing them in the AI Chat WebUI input box
kylehickinson
force-pushed
the
ios-aichat-associate-tab
branch
from
bb664df to
dad433c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows associating specific tabs that have already been loaded by referencing them in the AI Chat WebUI input box
Resolves brave/brave-browser#50196