Fix pyenv FAQ env var commands#144
Conversation
When using pyenv and global not set (defaulting to system) or global set to `system` the Launcher was unable to determine correct version to use. Fixed by using `pyenv exec` to correctly determine current Python version instead of parsing pyenv config files. Fixes brettcannon#141
brettcannon
left a comment
There was a problem hiding this comment.
One tricky thing with this compared to the old solution is PY_PYTHON is the default version to use when no specific major version is requested, e.g. it's not the same as PY_PYTHON2. That means this isn't technically right as you have to make an assumption as to what major version of Python people want to depend on compared to the solution of reading (pyenv root)/version).
Maybe it's better to list both solutions?
2227f5f to
72af0a0
Compare
|
I merged your suggestions but then changed my mind and reverted as I think there has been a misunderstanding.
The use of I hope this make sense? |
|
Then please drop the |
Co-authored-by: Brett Cannon <brett@python.org>
|
I agree, was including it for completeness for |
brettcannon
left a comment
There was a problem hiding this comment.
I just realized the changes were made against the main copy of the README and not the template which the README is generated from. Would you mind applying the changes to https://github.com/brettcannon/python-launcher/blob/main/docs/readme/template.md instead?
|
Thanks for the help with this! |
When using pyenv and global not set (defaulting to system) or global set to
systemthe Launcher was unable to determine correct version to use.Fixed by using
pyenv execto correctly determine current Python version instead of parsing pyenv config files.Fixes #141