Skip to content

Add Fedora installation instructions#148

Merged
brettcannon merged 4 commits intobrettcannon:mainfrom
hroncok:patch-1
Sep 10, 2021
Merged

Add Fedora installation instructions#148
brettcannon merged 4 commits intobrettcannon:mainfrom
hroncok:patch-1

Conversation

@hroncok
Copy link
Copy Markdown
Contributor

@hroncok hroncok commented Sep 3, 2021

cc @decathorpe

This is still in the process of being available, so don't merge yet, please. I'll mark this as ready for review once the command actually works on Fedora 34.

@hroncok hroncok marked this pull request as ready for review September 5, 2021 18:22
@hroncok
Copy link
Copy Markdown
Contributor Author

hroncok commented Sep 5, 2021

The command now actually works on Fedora 34.

@brettcannon brettcannon self-assigned this Sep 8, 2021
@brettcannon
Copy link
Copy Markdown
Owner

@hroncok I just got back from vacation, but this is in my review queue so I will get to it.

But I did want to ask you and @decathorpe if #146 would make your lives easier by having a .deb config for something like https://github.com/mmstick/cargo-deb live in the repo itself? Or is it not really helpful to you in the end? The key thing for me is having someone help verify the file doesn't accidentally break since a .deb file isn't how I'm installing the Launcher for myself.

@decathorpe
Copy link
Copy Markdown
Contributor

Our Rust packaging tools work almost exactly how cargo works without "special sauce" or configuration files (basically only "cargo install", with very basic configuration to tell it where to look for crate dependencies, and where to copy installed binaries), so adding configuration files to crate sources directly is not necessary for us.

Also we're dealing with RPM packages here, so I can't really help with deb stuff at all :)

@brettcannon
Copy link
Copy Markdown
Owner

Sorry about the distro confusion! Long day of catch-up after vacation 😅

Comment thread README.md Outdated
@brettcannon brettcannon merged commit 4ab2f55 into brettcannon:main Sep 10, 2021
@brettcannon
Copy link
Copy Markdown
Owner

Thanks for getting this into Fedora!

@hroncok hroncok deleted the patch-1 branch September 14, 2021 21:39
@brettcannon brettcannon added the impact-maintenance Maintenance of the code/project label Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact-maintenance Maintenance of the code/project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants