Skip to content

Use named parameters with format! #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 2 commits into from
Feb 3, 2023
Merged

Use named parameters with format! #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
103fb27
Use named parameters with `format!`
brettcannon Feb 3, 2023
ad93379
Handle `panic!` as well
brettcannon Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/cli_system_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ fn from_main_help() {
assert_eq!(env_state.python37, python_path);
assert!(message.contains(python_path.to_str().unwrap()));
}
_ => panic!("{:?} flag did not return Action::Help", flag),
_ => panic!("{flag:?} flag did not return Action::Help"),
}
}
}
Expand Down Expand Up @@ -82,7 +82,7 @@ fn from_main_by_flag() {
}
Ok(Action::Help(_, _)) => panic!("Got back help"),
Ok(Action::List(_)) => panic!("Got back a list of executables"),
Err(error) => panic!("No executable found in default case: {:?}", error),
Err(error) => panic!("No executable found in default case: {error:?}"),
}

match Action::from_main(&[launcher_location.clone(), "-2".to_string()]) {
Expand Down
4 changes: 2 additions & 2 deletions tests/main_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ fn exact_version() {
let python = python_launcher::find_executable(RequestedVersion::Any)
.expect("no Python executable found");
let version = ExactVersion::from_path(&python).unwrap();
let version_flag = format!("-{}", version);
let version_flag = format!("-{version}");
let result = py_executable()
.args([
version_flag.as_str(),
Expand Down Expand Up @@ -112,7 +112,7 @@ fn logging_output() {
#[test_case("3."; "invalid version specifier")]
#[test_case("0.1"; "non-existent version")]
fn version_failure(version: &str) {
let flag = format!("-{}", version);
let flag = format!("-{version}");
let result = py_executable().arg(flag).assert();

result.failure().stdout(str::is_empty());
Expand Down