Skip to content

feat(cmd): Add S3-SQS Handler#301

Merged
jtan-brex merged 4 commits intobrexhq:mainfrom
jshlbrd:jshlbrd/feat/aws-s3sqs
Jun 26, 2025
Merged

feat(cmd): Add S3-SQS Handler#301
jtan-brex merged 4 commits intobrexhq:mainfrom
jshlbrd:jshlbrd/feat/aws-s3sqs

Conversation

@jshlbrd
Copy link
Contributor

@jshlbrd jshlbrd commented Jun 13, 2025

Description

  • Adds an S3 -> SQS handler to the AWS Lambda application.
  • Refactors all S3 handlers to use the same ingest function.

Motivation and Context

The AWS Lambda app was missing support for S3 notifications sent over SQS. There's some complexity with this architecture because SQS can also encapsulate SNS, but this change covers both uses under the AWS_S3_SQS handler.

How Has This Been Tested?

This was tested in a production AWS account using an SNS encapsulated SQS queue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review June 13, 2025 13:28
@jshlbrd jshlbrd requested a review from a team as a code owner June 13, 2025 13:28
Copy link
Contributor

@jtan-brex jtan-brex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jshlbrd Thanks for incorporating this! Changes looked good 👍 Had one question about error handling method.

@jtan-brex jtan-brex merged commit ee1e551 into brexhq:main Jun 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants