fix(deps): remove aws-sdk-go v1#311
Conversation
`aws-sdk-go` v1 has reached EOL. This removes all remaining references to it. - The `String` helper functions do not exist anymore. - `xray` has a newer version that uses v2. - Error handling has changed to use smithy.
7f85b5a to
f5286ca
Compare
Greptile Overview
|
There was a problem hiding this comment.
Additional Comments (2)
-
transform/send_aws_sns.go, line 211-214 (link)logic: If AWS returns
nilforr.Id, this will convert to empty string andstrconv.Atoi("")will return error "invalid syntax", causing retry to fail -
transform/send_aws_sqs.go, line 224-227 (link)logic: If AWS returns
nilforr.Id, this will convert to empty string andstrconv.Atoi("")will return error "invalid syntax", causing retry to fail
8 files reviewed, 2 comments
andrew-kline
left a comment
There was a problem hiding this comment.
looks good otherwise, thanks for doing this!
|
@greptileai please re-review |
Description
aws-sdk-gov1 has reached EOL (#312). This removes all remaining references to it.Stringhelper functions do not exist anymore, so I replaced them based on the source code.xrayhas a newer version that uses v2. See release notes.Motivation and Context
Without these changes tools like Wiz will flag Substation for using EOL software.
How Has This Been Tested?
Types of changes
Checklist: