fix: process.IPDatabase Errors, condition.IP Type#44
Merged
Conversation
shellcromancer
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Discovered a bug in the IPDatabase processor when doing lower-level integration prep work -- if concurrency is active, then opening and accessing the database can randomly fail, but opening the database then putting it into the map fixes the problem.
While working on this I noticed two other things:
How Has This Been Tested?
Generated a list of random IP addresses using IPVOID and tested different concurrency settings using the file app (SUBSTATION_CONCURRENCY=1, SUBSTATION_CONCURRENCY=2, SUBSTATION_CONCURRENCY=6). Unrelated to this change, using high concurrency settings (2+) when loading files from remote locations (HTTP) caused massive slowdown in runtime. We should encourage users to do local cacheing of files instead of pulling them from remote sources on every invocation, even if we don't provide tools to do the cacheing.
Types of changes
Checklist: